]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 12 Apr 2025 10:15:00 +0000 (13:15 +0300)
committerBartosz Golaszewski <brgl@bgdev.pl>
Mon, 14 Apr 2025 20:25:20 +0000 (22:25 +0200)
This code is intended to reject strings that start with "_sysfs" but the
strcmp() limit is wrong so checks the whole string instead of the prefix.

Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Koichiro Den <koichiro.den@canonical.com>
Link: https://lore.kernel.org/r/30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-aggregator.c

index dde969f29ee2b06a650e5ecda969b0a156148102..b4c9e373a6ecb22e2f462cfa2010690d47dbc361 100644 (file)
@@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name)
         * for devices create via legacy sysfs interface.
         */
        if (strncmp(name, AGGREGATOR_LEGACY_PREFIX,
-                   sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0)
+                   sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0)
                return ERR_PTR(-EINVAL);
 
        /* arg space is unneeded */