]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: Annotate that all paths in hva_to_pfn() might sleep
authorSean Christopherson <seanjc@google.com>
Thu, 10 Oct 2024 18:23:15 +0000 (11:23 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 25 Oct 2024 16:57:58 +0000 (12:57 -0400)
Now that hva_to_pfn() no longer supports being called in atomic context,
move the might_sleep() annotation from hva_to_pfn_slow() to hva_to_pfn().

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20241010182427.1434605-14-seanjc@google.com>

virt/kvm/kvm_main.c

index c7506eb2308650ab9610dede78579058deb396ea..c60b542c7241bc168183968db867353c3e51f94c 100644 (file)
@@ -2804,8 +2804,6 @@ static int hva_to_pfn_slow(unsigned long addr, bool *async, bool write_fault,
        struct page *page;
        int npages;
 
-       might_sleep();
-
        if (writable)
                *writable = write_fault;
 
@@ -2939,6 +2937,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool interruptible, bool *async,
        kvm_pfn_t pfn;
        int npages, r;
 
+       might_sleep();
+
        if (hva_to_pfn_fast(addr, write_fault, writable, &pfn))
                return pfn;