]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 1586698 - Add proper autocomplete attributes for password change fields
authorTim Nguyen <nt1m@users.noreply.github.com>
Mon, 7 Oct 2019 14:19:23 +0000 (15:19 +0100)
committerdklawren <dklawren@users.noreply.github.com>
Mon, 7 Oct 2019 14:19:23 +0000 (10:19 -0400)
template/en/default/account/password/set-forgotten-password.html.tmpl
template/en/default/account/prefs/account.html.tmpl
template/en/default/account/reset-password.html.tmpl

index f5a218a895ae49df96726f9efb33fd61ef4e0df6..2db7b18ca75222b4ae9902cd4d661b5f1cd0fd8c 100644 (file)
         <tr>
           <th align="right">New Password:</th>
           <td>
-            <input type="password" name="password" id="new_password1" required>
+            <input autocomplete="new-password" type="password" name="password" id="new_password1" required>
           </td>
         </tr>
 
         <tr>
           <th align="right">New Password Again:</th>
           <td>
-            <input type="password" name="matchpassword" id="new_password2" required>
+            <input autocomplete="new-password" type="password" name="matchpassword" id="new_password2" required>
           </td>
         </tr>
 
index 8f9bf6a0e9c815a34ec02311fad560a81c4da31d..023d4890d84b607862d1a0bae0005eae9bc08ea0 100644 (file)
@@ -65,7 +65,7 @@
           <th align="right">Current password:</th>
           <td>
             <input type="hidden" name="old_login" value="[% user.login FILTER html %]">
-            <input type="password" name="old_password" id="old_password">
+            <input autocomplete="current-password" type="password" name="old_password" id="old_password">
             <a href="#" id="forgot-password">I forgot my password</a>
           </td>
         </tr>
           <tr>
             <th align="right">New password:</th>
             <td>
-              <input type="password" name="new_password1" id="new_password1">
+              <input autocomplete="new-password" type="password" name="new_password1" id="new_password1">
               [% INCLUDE "mfa/protected.html.tmpl" %]
             </td>
           </tr>
           <tr>
             <th align="right">Confirm new password:</th>
             <td>
-              <input type="password" name="new_password2" id="new_password2">
+              <input autocomplete="new-password" type="password" name="new_password2" id="new_password2">
             </td>
           </tr>
         [% END %]
index aa8be0a64eadaabe62fe5125a201c5ed2a9e4232..d4dd1aede8237885b8ebdd2cb071113ea94c14cb 100644 (file)
@@ -111,7 +111,7 @@ $(function() {
     <div class="field-row">
       <div class="field-name">Current Password</div>
       <div class="field-value">
-        <input type="password" name="old_password" id="old_password" size="30" required>
+        <input autocomplete="current-password" type="password" name="old_password" id="old_password" size="30" required>
       </div>
     </div>
     <div class="field-hr">&nbsp;</div>
@@ -119,13 +119,13 @@ $(function() {
     <div class="field-row">
       <div class="field-name">New Password</div>
       <div class="field-value">
-        <input type="password" name="new_password1" id="new_password1" size="30" required>
+        <input autocomplete="new-password" type="password" name="new_password1" id="new_password1" size="30" required>
       </div>
     </div>
     <div class="field-row">
       <div class="field-name">New Password</div>
       <div class="field-value">
-        <input type="password" name="new_password2" id="new_password2" size="30" required>
+        <input autocomplete="new-password" type="password" name="new_password2" id="new_password2" size="30" required>
         (again)
       </div>
     </div>