]> git.ipfire.org Git - thirdparty/git.git/commitdiff
log: drop "--cc implies -m" logic
authorJeff King <peff@peff.net>
Wed, 29 Jul 2020 20:10:17 +0000 (16:10 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 29 Jul 2020 20:43:57 +0000 (13:43 -0700)
This was added by 82dee4160c (log: show merge commit when --cc is given,
2015-08-20), which explains why we need it. But that commit failed to
notice that setup_revisions() already does the same thing, since
cd2bdc5309 (Common option parsing for "git log --diff" and friends,
2006-04-14).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/log.c

index d104d5c6889ba2d2ffaaeafa08fbfcd759d8bc92..281d2ae8eb176ecb3f5c0ffd7e82746a3895fd77 100644 (file)
@@ -731,10 +731,6 @@ static void log_setup_revisions_tweak(struct rev_info *rev,
        /* Turn --cc/-c into -p --cc/-c when -p was not given */
        if (!rev->diffopt.output_format && rev->combine_merges)
                rev->diffopt.output_format = DIFF_FORMAT_PATCH;
-
-       /* Turn -m on when --cc/-c was given */
-       if (rev->combine_merges)
-               rev->ignore_merges = 0;
 }
 
 int cmd_log(int argc, const char **argv, const char *prefix)