]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: arm_scmi: Fix voltage description in failure cases
authorEtienne Carriere <etienne.carriere@foss.st.com>
Thu, 25 Jul 2024 06:53:17 +0000 (08:53 +0200)
committerSudeep Holla <sudeep.holla@arm.com>
Fri, 9 Aug 2024 13:21:51 +0000 (14:21 +0100)
Reset the reception buffer max size when a voltage domain description
request fails, for example when the voltage domain returns an access
permission error (SCMI_ERR_ACCESS) unless what only a single 32bit
word is read back for the remaining voltage description requests
responses leading to invalid information. The side effect of this
issue is that the voltage regulators registered from those remaining
SCMI voltage domain were assigned a wrong regulator name.

Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Message-Id: <20240725065317.3758165-1-etienne.carriere@foss.st.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/voltage.c

index 2175ffd6cef534870a8e7f41a66d30981a7bc845..f1a7c04ae82071f6e852b08323150f5ed13198b9 100644 (file)
@@ -229,8 +229,10 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph,
                /* Retrieve domain attributes at first ... */
                put_unaligned_le32(dom, td->tx.buf);
                /* Skip domain on comms error */
-               if (ph->xops->do_xfer(ph, td))
+               if (ph->xops->do_xfer(ph, td)) {
+                       ph->xops->reset_rx_to_maxsz(ph, td);
                        continue;
+               }
 
                v = vinfo->domains + dom;
                v->id = dom;