]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/msm/a6xx: Only print the GMU firmware version once
authorKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Thu, 13 Feb 2025 16:44:43 +0000 (17:44 +0100)
committerRob Clark <robdclark@chromium.org>
Sat, 15 Feb 2025 17:22:53 +0000 (09:22 -0800)
We only fetch it once from userland, so let's also only notify the
user once and not on every runtime resume.

As you can notice by the tags chain, more than one user found this
annoying.

Reported-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
Suggested-by: Abel Vesa <abel.vesa@linaro.org>
Suggested-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/637062/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a6xx_gmu.c

index 65d38b25c0707a3c7fff08d110b4ac2b9d410473..699b0dd34b18f0ec811e975779ba95991d485098 100644 (file)
@@ -813,10 +813,10 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu)
        }
 
        ver = gmu_read(gmu, REG_A6XX_GMU_CORE_FW_VERSION);
-       DRM_INFO("Loaded GMU firmware v%u.%u.%u\n",
-                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MAJOR__MASK, ver),
-                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MINOR__MASK, ver),
-                FIELD_GET(A6XX_GMU_CORE_FW_VERSION_STEP__MASK, ver));
+       DRM_INFO_ONCE("Loaded GMU firmware v%u.%u.%u\n",
+                     FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MAJOR__MASK, ver),
+                     FIELD_GET(A6XX_GMU_CORE_FW_VERSION_MINOR__MASK, ver),
+                     FIELD_GET(A6XX_GMU_CORE_FW_VERSION_STEP__MASK, ver));
 
        return 0;
 }