thread: Don't acquire lock for thread_cleanup_push/pop

This is called only by the thread for its own thread_t, and does not need
synchronization.

diff --git a/src/libstrongswan/threading/thread.c b/src/libstrongswan/threading/thread.c
index 2bf86c1589ff4bd701730e7a29d96ff6db12d14f..91a2d345d4159c85b1bb03f3d257aa1564ba80e6 100644 (file)
--- a/src/libstrongswan/threading/thread.c
+++ b/src/libstrongswan/threading/thread.c
@@ -374,9 +374,7 @@ void thread_cleanup_push(thread_cleanup_t cleanup, void *arg)
                .arg = arg,
        );
 
-       this->mutex->lock(this->mutex);
        this->cleanup_handlers->insert_last(this->cleanup_handlers, handler);
-       this->mutex->unlock(this->mutex);
 }
 
 /**
@@ -387,15 +385,12 @@ void thread_cleanup_pop(bool execute)
        private_thread_t *this = (private_thread_t*)thread_current();
        cleanup_handler_t *handler;
 
-       this->mutex->lock(this->mutex);
        if (this->cleanup_handlers->remove_last(this->cleanup_handlers,
                                                                                        (void**)&handler) != SUCCESS)
        {
-               this->mutex->unlock(this->mutex);
                DBG1(DBG_LIB, "!!! THREAD CLEANUP ERROR !!!");
                return;
        }
-       this->mutex->unlock(this->mutex);
 
        if (execute)
        {