t5512: stop losing return codes of git commands

In a pipe, only the return code of the last command is used. Thus, all
other commands will have their return codes masked. Rewrite pipes so
that there are no git commands upstream so that their failure is
reported.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh
index 98de7f5933e4db1c73b30aba8943e5fa5d40a64a..e98c3a01741d8ed830d6342dd566b24eee25e8b6 100755 (executable)
--- a/t/t5512-ls-remote.sh
+++ b/t/t5512-ls-remote.sh
@@ -21,11 +21,11 @@ test_expect_success setup '
        git tag mark1.1 &&
        git tag mark1.2 &&
        git tag mark1.10 &&
-       git show-ref --tags -d | sed -e "s/ /   /" >expected.tag &&
-       (
-               echo "$(git rev-parse HEAD)     HEAD" &&
-               git show-ref -d | sed -e "s/ /  /"
-       ) >expected.all &&
+       git show-ref --tags -d >expected.tag.raw &&
+       sed -e "s/ /    /" expected.tag.raw >expected.tag &&
+       generate_references HEAD >expected.all &&
+       git show-ref -d >refs &&
+       sed -e "s/ /    /" refs >>expected.all &&
 
        git remote add self "$(pwd)/.git"
 '
@@ -185,8 +185,8 @@ do
                test_config $configsection.hiderefs refs/tags &&
                git ls-remote . >actual &&
                test_unconfig $configsection.hiderefs &&
-               git ls-remote . |
-               sed -e "/       refs\/tags\//d" >expect &&
+               git ls-remote . >expect.raw &&
+               sed -e "/       refs\/tags\//d" expect.raw >expect &&
                test_cmp expect actual
        '