Performance optimization in sqlite3ViewGetColumnNames().

FossilOrigin-Name: 390717e68800af9b71acd635cf6cb123f9a591276df511f11462b42960f9a70c

diff --git a/manifest b/manifest
index 5d003aaa49c116dedadf88b60ad9fbd9c6c1b3c1..dfa107fe51a5ded7dfd8ed51abc5b255a87b4eaa 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Fix\sa\sharmless\scompiler\swarning.
-D 2022-07-25T22:02:35.792
+C Performance\soptimization\sin\ssqlite3ViewGetColumnNames().
+D 2022-07-25T22:31:04.172
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -513,7 +513,7 @@ F src/btmutex.c 8acc2f464ee76324bf13310df5692a262b801808984c1b79defb2503bbafadb6
 F src/btree.c 1307d57f65023c9f37c2b6c62253343fca63877f161f694a593b14c0883cedda
 F src/btree.h 74d64b8f28cfa4a894d14d4ed64fa432cd697b98b61708d4351482ae15913e22
 F src/btreeInt.h 8ce1332edd89dfd2461d561ac10a0ab5601c8e06200cb5230596c3caaf54482e
-F src/build.c abba8a3f8529d3f3808e7cfa580e4541471ea010635d2a23365c0de8b22128b5
+F src/build.c 941d7ff0c38f8b16ae5ffff8d76a7657701115a42651d9e52054c12ef0a6ad79
 F src/callback.c 4c19af69835787bfe790ac560f3071a824eb629f34e41f97b52ce5235c77de1c
 F src/complete.c a3634ab1e687055cd002e11b8f43eb75c17da23e
 F src/ctime.c 026dbdcdbd8c3cde98a88483ee88310ff43150ab164ad768f12cc700a11495ad
@@ -1981,8 +1981,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 35066b1446228bf030795e7868509c7b54a5681984ac28bf43123f8fac2e361e
-R 14bc2153dd870c51d01ef34ec6804518
+P 9aba7417c60b30b44c051580f0f997a4d2fc86bc811b532d175305ad4c181fc6
+R 6455264c445f081e2167b0aeb515b69f
 U drh
-Z 26d5ce22a72ed03f342cb02915325d2e
+Z 96e54ff79e297fd32468d545082b5401
 # Remove this line to create a well-formed Fossil manifest.

diff --git a/manifest.uuid b/manifest.uuid
index 269b8d0bb951028c443e3a63f386e20b2d399071..cdf20ffd4db37e073286c777340231f40b5e71da 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-9aba7417c60b30b44c051580f0f997a4d2fc86bc811b532d175305ad4c181fc6
\ No newline at end of file
+390717e68800af9b71acd635cf6cb123f9a591276df511f11462b42960f9a70c
\ No newline at end of file

diff --git a/src/build.c b/src/build.c
index 4b27d5cf842c6a36b51ff3b400f318ea3b9ec23d..47aa8bc57c65cf9b3c1481197595a8dfef8b0252 100644 (file)
--- a/src/build.c
+++ b/src/build.c
@@ -3042,7 +3042,7 @@ create_view_fail:
 ** the columns of the view in the pTable structure.  Return the number
 ** of errors.  If an error is seen leave an error message in pParse->zErrMsg.
 */
-int sqlite3ViewGetColumnNames(Parse *pParse, Table *pTable){
+static SQLITE_NOINLINE int viewGetColumnNames(Parse *pParse, Table *pTable){
   Table *pSelTab;   /* A fake table from which we get the result set */
   Select *pSel;     /* Copy of the SELECT that implements the view */
   int nErr = 0;     /* Number of errors encountered */
@@ -3165,6 +3165,11 @@ int sqlite3ViewGetColumnNames(Parse *pParse, Table *pTable){
 #endif /* SQLITE_OMIT_VIEW */
   return nErr;  
 }
+int sqlite3ViewGetColumnNames(Parse *pParse, Table *pTable){
+  assert( pTable!=0 );
+  if( !IsVirtual(pTable) && pTable->nCol>0 ) return 0;
+  return viewGetColumnNames(pParse, pTable);
+}
 #endif /* !defined(SQLITE_OMIT_VIEW) || !defined(SQLITE_OMIT_VIRTUALTABLE) */
 
 #ifndef SQLITE_OMIT_VIEW