]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/qaic: Change to use DEFINE_SHOW_ATTRIBUTE macro
authorLonglong Xia <xialonglong@kylinos.cn>
Mon, 19 Aug 2024 09:58:16 +0000 (17:58 +0800)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Fri, 13 Sep 2024 18:40:46 +0000 (12:40 -0600)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
No functional change.

Signed-off-by: Longlong Xia <xialonglong@kylinos.cn>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240819095816.447096-1-xialonglong@kylinos.cn
drivers/accel/qaic/qaic_debugfs.c

index 20b653d99e524a5c0d451b68b66ffcd10547377d..ba0cf2f94732cc6178abeaeab40adf6eb830ad19 100644 (file)
@@ -64,20 +64,9 @@ static int bootlog_show(struct seq_file *s, void *unused)
        return 0;
 }
 
-static int bootlog_fops_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, bootlog_show, inode->i_private);
-}
-
-static const struct file_operations bootlog_fops = {
-       .owner = THIS_MODULE,
-       .open = bootlog_fops_open,
-       .read = seq_read,
-       .llseek = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(bootlog);
 
-static int read_dbc_fifo_size(struct seq_file *s, void *unused)
+static int fifo_size_show(struct seq_file *s, void *unused)
 {
        struct dma_bridge_chan *dbc = s->private;
 
@@ -85,20 +74,9 @@ static int read_dbc_fifo_size(struct seq_file *s, void *unused)
        return 0;
 }
 
-static int fifo_size_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, read_dbc_fifo_size, inode->i_private);
-}
-
-static const struct file_operations fifo_size_fops = {
-       .owner = THIS_MODULE,
-       .open = fifo_size_open,
-       .read = seq_read,
-       .llseek = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fifo_size);
 
-static int read_dbc_queued(struct seq_file *s, void *unused)
+static int queued_show(struct seq_file *s, void *unused)
 {
        struct dma_bridge_chan *dbc = s->private;
        u32 tail = 0, head = 0;
@@ -115,18 +93,7 @@ static int read_dbc_queued(struct seq_file *s, void *unused)
        return 0;
 }
 
-static int queued_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, read_dbc_queued, inode->i_private);
-}
-
-static const struct file_operations queued_fops = {
-       .owner = THIS_MODULE,
-       .open = queued_open,
-       .read = seq_read,
-       .llseek = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(queued);
 
 void qaic_debugfs_init(struct qaic_drm_device *qddev)
 {