drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

If devm_i2c_new_dummy_device() fails then we were supposed to return an
error code, but instead the function continues and will crash on the next
line.  Add the missing return statement.

Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Liu Ying <victor.liu@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/804a758b-f2e7-4116-b72d-29bc8905beed@stanley.mountain

diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
index cbabd4e20d3ebbe632a60f7cac73302815fab7d8..5f138a5692c7c52aa910a0a63552c9603303e7c4 100644 (file)
--- a/drivers/gpu/drm/bridge/ite-it6263.c
+++ b/drivers/gpu/drm/bridge/ite-it6263.c
@@ -845,8 +845,8 @@ static int it6263_probe(struct i2c_client *client)
        it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter,
                                                 LVDS_INPUT_CTRL_I2C_ADDR);
        if (IS_ERR(it->lvds_i2c))
-               dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
-                             "failed to allocate I2C device for LVDS\n");
+               return dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
+                                    "failed to allocate I2C device for LVDS\n");
 
        it->lvds_regmap = devm_regmap_init_i2c(it->lvds_i2c,
                                               &it6263_lvds_regmap_config);