]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fs: remove dead check
authorChristian Brauner <brauner@kernel.org>
Sat, 4 Nov 2023 14:00:12 +0000 (15:00 +0100)
committerChristian Brauner <brauner@kernel.org>
Sat, 18 Nov 2023 13:59:24 +0000 (14:59 +0100)
Above we call super_lock_excl() which waits until the superblock is
SB_BORN and since SB_BORN is never unset once set this check can never
fire. Plus, we also hold an active reference at this point already so
this superblock can't even be shutdown.

Link: https://lore.kernel.org/r/20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org
Tested-by: Chandan Babu R <chandanbabu@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/super.c

index faeab453e6e9536034700eb96091a247a85dd85b..d2b026566dea3267cb456da78510e85853f8e6b7 100644 (file)
@@ -1996,11 +1996,6 @@ retry:
                goto retry;
        }
 
-       if (!(sb->s_flags & SB_BORN)) {
-               super_unlock_excl(sb);
-               return 0;       /* sic - it's "nothing to do" */
-       }
-
        if (sb_rdonly(sb)) {
                /* Nothing to do really... */
                sb->s_writers.freeze_holders |= who;