t/t3903-stash.sh: replace test [-d|-f] with test_path_is_*

Use test_path_is_* to replace test [-d|-f] because that give more
explicit debugging information. And it doesn't change the semantics.

Signed-off-by: COGONI Guillaume <cogoni.guillaume@gmail.com>
Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 686747e55a301a661d75c63223a7d682c30dbd4b..d6a37692f66600f9b074369beb3f02c18dee6528 100755 (executable)
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -487,7 +487,7 @@ test_expect_failure 'stash directory to file' '
        rm -fr dir &&
        echo bar >dir &&
        git stash save "directory to file" &&
-       test -d dir &&
+       test_path_is_dir dir &&
        test foo = "$(cat dir/file)" &&
        test_must_fail git stash apply &&
        test bar = "$(cat dir)" &&
@@ -500,10 +500,10 @@ test_expect_failure 'stash file to directory' '
        mkdir file &&
        echo foo >file/file &&
        git stash save "file to directory" &&
-       test -f file &&
+       test_path_is_file file &&
        test bar = "$(cat file)" &&
        git stash apply &&
-       test -f file/file &&
+       test_path_is_file file/file &&
        test foo = "$(cat file/file)"
 '