bcachefs: Don't unlock trans before data_update_init()

data_update_init() does need to do btree operations, delay doing the
unlock-before-io.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/data_update.c b/fs/bcachefs/data_update.c
index 1216729c20e8f50e08a84bebad6dc16b0b8353d5..63a10ea83c97432ec2774b32ee4e1f7ac0bf308e 100644 (file)
--- a/fs/bcachefs/data_update.c
+++ b/fs/bcachefs/data_update.c
@@ -980,6 +980,8 @@ int bch2_data_update_init(struct btree_trans *trans,
                goto out_nocow_unlock;
        }
 
+       bch2_trans_unlock(trans);
+
        ret = __bch2_data_update_bios_init(m, c, io_opts, buf_bytes);
        if (ret)
                goto out_nocow_unlock;

diff --git a/fs/bcachefs/move.c b/fs/bcachefs/move.c
index 857519cdac4eeb713e945827ad5bf421d4ca7d54..fc1a7a04cb15ee46ee3d25e15585904d4410d325 100644 (file)
--- a/fs/bcachefs/move.c
+++ b/fs/bcachefs/move.c
@@ -359,16 +359,14 @@ int bch2_move_extent(struct moving_context *ctxt,
                return 0;
        }
 
-       /*
-        * Before memory allocations & taking nocow locks in
-        * bch2_data_update_init():
-        */
-       bch2_trans_unlock(trans);
-
-       struct moving_io *io = kzalloc(sizeof(struct moving_io), GFP_KERNEL);
+       struct moving_io *io = allocate_dropping_locks(trans, ret,
+                               kzalloc(sizeof(struct moving_io), _gfp));
        if (!io)
                goto err;
 
+       if (ret)
+               goto err_free;
+
        INIT_LIST_HEAD(&io->io_list);
        io->write.ctxt          = ctxt;
        io->read_sectors        = k.k->size;
@@ -388,6 +386,8 @@ int bch2_move_extent(struct moving_context *ctxt,
                io->write.op.c          = c;
                io->write.data_opts     = data_opts;
 
+               bch2_trans_unlock(trans);
+
                ret = bch2_data_update_bios_init(&io->write, c, &io_opts);
                if (ret)
                        goto err_free;