]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf/arm-cmn: Clean up unnecessary NUMA_NO_NODE check
authorRobin Murphy <robin.murphy@arm.com>
Wed, 4 Sep 2024 18:41:54 +0000 (19:41 +0100)
committerWill Deacon <will@kernel.org>
Fri, 6 Sep 2024 11:58:06 +0000 (12:58 +0100)
Checking for NUMA_NO_NODE is a misleading and, on reflection, entirely
unnecessary micro-optimisation. If it ever did happen that an incoming
CPU has no NUMA affinity while the current CPU does, a questionably-
useful PMU migration isn't the biggest thing wrong with that picture...

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/00634da33c21269a00844140afc7cc3a2ac1eb4d.1725474584.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/arm-cmn.c

index 0266ff041e0b0f0b1d2b7d49585b1537f0053a81..62d4782da7e48cc916ac0a016d71f07fcfc1645e 100644 (file)
@@ -2023,7 +2023,7 @@ static int arm_cmn_pmu_online_cpu(unsigned int cpu, struct hlist_node *cpuhp_nod
 
        cmn = hlist_entry_safe(cpuhp_node, struct arm_cmn, cpuhp_node);
        node = dev_to_node(cmn->dev);
-       if (node != NUMA_NO_NODE && cpu_to_node(cmn->cpu) != node && cpu_to_node(cpu) == node)
+       if (cpu_to_node(cmn->cpu) != node && cpu_to_node(cpu) == node)
                arm_cmn_migrate(cmn, cpu);
        return 0;
 }