]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mailbox: mpfs: fix copy and paste bug in probe
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 30 Nov 2024 10:07:23 +0000 (13:07 +0300)
committerJassi Brar <jassisinghbrar@gmail.com>
Sat, 18 Jan 2025 22:04:51 +0000 (16:04 -0600)
This code accidentally checks ->ctrl_base instead of ->mbox_base so the
error handling can never be triggered.

Fixes: a4123ffab9ec ("mailbox: mpfs: support new, syscon based, devicetree configuration")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/mailbox-mpfs.c

index 4df546e3b7eaebf214b27c1f6f07a29268c9f99f..d5d9effece9797e3423e69e805a3cdda60132731 100644 (file)
@@ -251,7 +251,7 @@ static inline int mpfs_mbox_syscon_probe(struct mpfs_mbox *mbox, struct platform
                return PTR_ERR(mbox->sysreg_scb);
 
        mbox->mbox_base = devm_platform_ioremap_resource(pdev, 0);
-       if (IS_ERR(mbox->ctrl_base))
+       if (IS_ERR(mbox->mbox_base))
                return PTR_ERR(mbox->mbox_base);
 
        return 0;