]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
smc: rename smc_find_ism_store_rc to reflect broader usage
authorDust Li <dust.li@linux.alibaba.com>
Thu, 23 Oct 2025 02:00:12 +0000 (10:00 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 25 Oct 2025 01:48:03 +0000 (18:48 -0700)
The function smc_find_ism_store_rc() is used to record the reason
why a suitable device (either ISM or RDMA) could not be found.
However, its name suggests it is ISM-specific, which is misleading.

Rename it to better reflect its actual usage.

No functional changes.

Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251023020012.69609-1-dust.li@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/smc/af_smc.c

index 77b99e8ef35a49667e4fd50c3c9ecf3665dd5ae6..e9d0e62e0b1bc8c80a485b4894bbfbe99577dfe1 100644 (file)
@@ -2140,7 +2140,7 @@ static void smc_check_ism_v2_match(struct smc_init_info *ini,
        }
 }
 
-static void smc_find_ism_store_rc(u32 rc, struct smc_init_info *ini)
+static void smc_init_info_store_rc(u32 rc, struct smc_init_info *ini)
 {
        if (!ini->rc)
                ini->rc = rc;
@@ -2203,7 +2203,7 @@ static void smc_find_ism_v2_device_serv(struct smc_sock *new_smc,
        mutex_unlock(&smcd_dev_list.mutex);
 
        if (!ini->ism_dev[0]) {
-               smc_find_ism_store_rc(SMC_CLC_DECL_NOSMCD2DEV, ini);
+               smc_init_info_store_rc(SMC_CLC_DECL_NOSMCD2DEV, ini);
                goto not_found;
        }
 
@@ -2220,7 +2220,7 @@ static void smc_find_ism_v2_device_serv(struct smc_sock *new_smc,
                ini->ism_selected = i;
                rc = smc_listen_ism_init(new_smc, ini);
                if (rc) {
-                       smc_find_ism_store_rc(rc, ini);
+                       smc_init_info_store_rc(rc, ini);
                        /* try next active ISM device */
                        continue;
                }
@@ -2260,7 +2260,7 @@ static void smc_find_ism_v1_device_serv(struct smc_sock *new_smc,
                return;         /* V1 ISM device found */
 
 not_found:
-       smc_find_ism_store_rc(rc, ini);
+       smc_init_info_store_rc(rc, ini);
        ini->smcd_version &= ~SMC_V1;
        ini->ism_dev[0] = NULL;
        ini->is_smcd = false;
@@ -2311,7 +2311,7 @@ static void smc_find_rdma_v2_device_serv(struct smc_sock *new_smc,
        ini->smcrv2.daddr = smc_ib_gid_to_ipv4(smc_v2_ext->roce);
        rc = smc_find_rdma_device(new_smc, ini);
        if (rc) {
-               smc_find_ism_store_rc(rc, ini);
+               smc_init_info_store_rc(rc, ini);
                goto not_found;
        }
        if (!ini->smcrv2.uses_gateway)
@@ -2328,7 +2328,7 @@ static void smc_find_rdma_v2_device_serv(struct smc_sock *new_smc,
        if (!rc)
                return;
        ini->smcr_version = smcr_version;
-       smc_find_ism_store_rc(rc, ini);
+       smc_init_info_store_rc(rc, ini);
 
 not_found:
        ini->smcr_version &= ~SMC_V2;
@@ -2375,7 +2375,7 @@ static int smc_listen_find_device(struct smc_sock *new_smc,
        /* check for matching IP prefix and subnet length (V1) */
        prfx_rc = smc_listen_prfx_check(new_smc, pclc);
        if (prfx_rc)
-               smc_find_ism_store_rc(prfx_rc, ini);
+               smc_init_info_store_rc(prfx_rc, ini);
 
        /* get vlan id from IP device */
        if (smc_vlan_by_tcpsk(new_smc->clcsock, ini))
@@ -2402,7 +2402,7 @@ static int smc_listen_find_device(struct smc_sock *new_smc,
                int rc;
 
                rc = smc_find_rdma_v1_device_serv(new_smc, pclc, ini);
-               smc_find_ism_store_rc(rc, ini);
+               smc_init_info_store_rc(rc, ini);
                return (!rc) ? 0 : ini->rc;
        }
        return prfx_rc;