lib: io_stream_set_error() - Allow one of the parameters to be the old error

diff --git a/src/lib/iostream.c b/src/lib/iostream.c
index cb7d9fa6e19556e41a5d20bbd5219f8c72891efa..7d1762c491a31b53bb2d6a596bf96296ed4019c3 100644 (file)
--- a/src/lib/iostream.c
+++ b/src/lib/iostream.c
@@ -110,8 +110,11 @@ void io_stream_set_error(struct iostream_private *stream,
 void io_stream_set_verror(struct iostream_private *stream,
                          const char *fmt, va_list args)
 {
+       /* one of the parameters may be the old stream->error, so don't free
+          it before the new error is created. */
+       char *error = i_strdup_vprintf(fmt, args);
        i_free(stream->error);
-       stream->error = i_strdup_vprintf(fmt, args);
+       stream->error = error;
 }
 
 const char *io_stream_get_disconnect_reason(struct istream *input,