]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: Fix wrong length of devres array
authorPhilipp Stanner <phasta@kernel.org>
Wed, 12 Mar 2025 08:06:34 +0000 (09:06 +0100)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Fri, 14 Mar 2025 09:22:24 +0000 (09:22 +0000)
The array for the iomapping cookie addresses has a length of
PCI_STD_NUM_BARS. This constant, however, only describes standard BARs;
while PCI can allow for additional, special BARs.

The total number of PCI resources is described by constant
PCI_NUM_RESOURCES, which is also used in, e.g., pci_select_bars().

Thus, the devres array has so far been too small.

Change the length of the devres array to PCI_NUM_RESOURCES.

Link: https://lore.kernel.org/r/20250312080634.13731-3-phasta@kernel.org
Fixes: bbaff68bf4a4 ("PCI: Add managed partial-BAR request and map infrastructure")
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Cc: stable@vger.kernel.org # v6.11+
drivers/pci/devres.c

index 3431a7df3e0d9a196f9457a23aa73d82bd3e71b4..728ed0c7f70ac1fc39a90c21dde25db15d83a42e 100644 (file)
@@ -40,7 +40,7 @@
  * Legacy struct storing addresses to whole mapped BARs.
  */
 struct pcim_iomap_devres {
-       void __iomem *table[PCI_STD_NUM_BARS];
+       void __iomem *table[PCI_NUM_RESOURCES];
 };
 
 /* Used to restore the old INTx state on driver detach. */