]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
jbd2: correctly compare tids with tid_geq function in jbd2_fc_begin_commit
authorKemeng Shi <shikemeng@huaweicloud.com>
Thu, 1 Aug 2024 01:38:08 +0000 (09:38 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 27 Aug 2024 03:49:15 +0000 (23:49 -0400)
Use tid_geq to compare tids to work over sequence number wraps.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Cc: stable@kernel.org
Link: https://patch.msgid.link/20240801013815.2393869-2-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c

index 291a431f8aaf632afd4911596021325a75e50d31..33a975193f1f10d43fdd922c253277647c08a83f 100644 (file)
@@ -710,7 +710,7 @@ int jbd2_fc_begin_commit(journal_t *journal, tid_t tid)
                return -EINVAL;
 
        write_lock(&journal->j_state_lock);
-       if (tid <= journal->j_commit_sequence) {
+       if (tid_geq(journal->j_commit_sequence, tid)) {
                write_unlock(&journal->j_state_lock);
                return -EALREADY;
        }