]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ACPI: PCC: Fix race condition by removing static qualifier
authorPengjie Zhang <zhangpengjie2@huawei.com>
Wed, 10 Dec 2025 13:26:34 +0000 (21:26 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 15 Dec 2025 12:00:33 +0000 (13:00 +0100)
Local variable 'ret' in acpi_pcc_address_space_setup() is currently
declared as 'static'. This can lead to race conditions in a
multithreaded environment.

Remove the 'static' qualifier to ensure that 'ret' will be allocated
directly on the stack as a local variable.

Fixes: a10b1c99e2dc ("ACPI: PCC: Setup PCC Opregion handler only if platform interrupt is available")
Signed-off-by: Pengjie Zhang <zhangpengjie2@huawei.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: lihuisong@huawei.com
Cc: 6.2+ <stable@vger.kernel.org> # 6.2+
[ rjw: Changelog edits ]
Link: https://patch.msgid.link/20251210132634.2050033-1-zhangpengjie2@huawei.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_pcc.c

index 97064e943768ad9f1704effa13dddbc0876a9452..e3f302b9dee5f5a462115da37c9042d9ddba00ea 100644 (file)
@@ -52,7 +52,7 @@ acpi_pcc_address_space_setup(acpi_handle region_handle, u32 function,
        struct pcc_data *data;
        struct acpi_pcc_info *ctx = handler_context;
        struct pcc_mbox_chan *pcc_chan;
-       static acpi_status ret;
+       acpi_status ret;
 
        data = kzalloc(sizeof(*data), GFP_KERNEL);
        if (!data)