]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
authorLiang He <windhl@126.com>
Wed, 20 Jul 2022 13:10:03 +0000 (21:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Aug 2022 10:05:23 +0000 (12:05 +0200)
[ Upstream commit ebbbe23fdf6070e31509638df3321688358cc211 ]

In bcm5421_init(), we should call of_node_put() for the reference
returned by of_get_parent() which has increased the refcount.

Fixes: 3c326fe9cb7a ("[PATCH] ppc64: Add new PHY to sungem")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220720131003.1287426-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/sungem_phy.c

index 4daac5fda073cf75623c5fa6bacb70233f0da0f3..0d40d265b68861124b4dac076821ded4b7e4c563 100644 (file)
@@ -454,6 +454,7 @@ static int bcm5421_init(struct mii_phy* phy)
                int can_low_power = 1;
                if (np == NULL || of_get_property(np, "no-autolowpower", NULL))
                        can_low_power = 0;
+               of_node_put(np);
                if (can_low_power) {
                        /* Enable automatic low-power */
                        sungem_phy_write(phy, 0x1c, 0x9002);