]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
ALSA: vx222: Fix invalid endian conversions
authorTakashi Iwai <tiwai@suse.de>
Wed, 25 Jul 2018 15:10:11 +0000 (17:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Aug 2018 05:46:09 +0000 (07:46 +0200)
commit fff71a4c050ba46e305d910c837b99ba1728135e upstream.

The endian conversions used in vx2_dma_read() and vx2_dma_write() are
superfluous and even wrong on big-endian machines, as inl() and outl()
already do conversions.  Kill them.

Spotted by sparse, a warning like:
  sound/pci/vx222/vx222_ops.c:278:30: warning: incorrect type in argument 1 (different base types)

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/vx222/vx222_ops.c

index d4298af6d3eee6349fb2e3ca03c9c2f621aebae5..c0d0bf44f365b67e0c28321c352d146448c46339 100644 (file)
@@ -275,7 +275,7 @@ static void vx2_dma_write(struct vx_core *chip, struct snd_pcm_runtime *runtime,
                length >>= 2; /* in 32bit words */
                /* Transfer using pseudo-dma. */
                for (; length > 0; length--) {
-                       outl(cpu_to_le32(*addr), port);
+                       outl(*addr, port);
                        addr++;
                }
                addr = (u32 *)runtime->dma_area;
@@ -285,7 +285,7 @@ static void vx2_dma_write(struct vx_core *chip, struct snd_pcm_runtime *runtime,
        count >>= 2; /* in 32bit words */
        /* Transfer using pseudo-dma. */
        for (; count > 0; count--) {
-               outl(cpu_to_le32(*addr), port);
+               outl(*addr, port);
                addr++;
        }
 
@@ -313,7 +313,7 @@ static void vx2_dma_read(struct vx_core *chip, struct snd_pcm_runtime *runtime,
                length >>= 2; /* in 32bit words */
                /* Transfer using pseudo-dma. */
                for (; length > 0; length--)
-                       *addr++ = le32_to_cpu(inl(port));
+                       *addr++ = inl(port);
                addr = (u32 *)runtime->dma_area;
                pipe->hw_ptr = 0;
        }
@@ -321,7 +321,7 @@ static void vx2_dma_read(struct vx_core *chip, struct snd_pcm_runtime *runtime,
        count >>= 2; /* in 32bit words */
        /* Transfer using pseudo-dma. */
        for (; count > 0; count--)
-               *addr++ = le32_to_cpu(inl(port));
+               *addr++ = inl(port);
 
        vx2_release_pseudo_dma(chip);
 }