]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/vc4: plane: Add more debugging for LBM allocation
authorMaxime Ripard <mripard@kernel.org>
Fri, 21 Jun 2024 15:20:35 +0000 (16:20 +0100)
committerDave Stevenson <dave.stevenson@raspberrypi.com>
Mon, 9 Sep 2024 12:02:53 +0000 (13:02 +0100)
LBM allocations need a different size depending on the line length,
format, etc.

This can get tricky, and fail. Let's add some more prints to ease the
debugging when it does.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-12-dave.stevenson@raspberrypi.com
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_plane.c

index e4fcef11cf6f714c244fa63260d1e8291d4e1c21..16197c4b4b33eee298fdce669d2aa5e7b2bee2ef 100644 (file)
@@ -741,6 +741,7 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state)
 {
        struct drm_device *drm = state->plane->dev;
        struct vc4_dev *vc4 = to_vc4_dev(drm);
+       struct drm_plane *plane = state->plane;
        struct vc4_plane_state *vc4_state = to_vc4_plane_state(state);
        unsigned long irqflags;
        u32 lbm_size;
@@ -749,6 +750,9 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state)
        if (!lbm_size)
                return 0;
 
+       drm_dbg_driver(drm, "[PLANE:%d:%s] LBM Allocation Size: %u\n",
+                      plane->base.id, plane->name, lbm_size);
+
        if (WARN_ON(!vc4_state->lbm_offset))
                return -EINVAL;