iptables: close open file descriptors

Just for correctness, close some file descriptors that were opened.
(E.g. ip6tables-save reading from procfs files.)

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

diff --git a/ip6tables-restore.c b/ip6tables-restore.c
index 1d5efea2a17d5c2cf3b7f9bfef40487393f7553d..06a82aec3172ca5218dd942f6f3fca8251ec5ce5 100644 (file)
--- a/ip6tables-restore.c
+++ b/ip6tables-restore.c
@@ -454,5 +454,7 @@ int main(int argc, char *argv[])
                exit(1);
        }
 
+       if (in != NULL)
+               fclose(in);
        return 0;
 }

diff --git a/ip6tables-save.c b/ip6tables-save.c
index 97205c1c9e11b66d2e13535d2a67ad23d2d10e81..c59608fb210a846d2f965c95d7a07af012dc7595 100644 (file)
--- a/ip6tables-save.c
+++ b/ip6tables-save.c
@@ -54,6 +54,7 @@ static int for_each_table(int (*func)(const char *tablename))
                ret &= func(tablename);
        }
 
+       fclose(procfile);
        return ret;
 }
 

diff --git a/iptables-restore.c b/iptables-restore.c
index 2a797ccff85bb87856838779ea2030efbc9c017c..5108fda6a682416cec6580e0ad62a99f54b625a6 100644 (file)
--- a/iptables-restore.c
+++ b/iptables-restore.c
@@ -459,5 +459,7 @@ main(int argc, char *argv[])
                exit(1);
        }
 
+       if (in != NULL)
+               fclose(in);
        return 0;
 }

diff --git a/iptables-save.c b/iptables-save.c
index 6000b494c5b770062afd1d9730bb78bbea049ad7..f63ee6b1595bbbd69cf244682cd49750c3bf597c 100644 (file)
--- a/iptables-save.c
+++ b/iptables-save.c
@@ -52,6 +52,7 @@ static int for_each_table(int (*func)(const char *tablename))
                ret &= func(tablename);
        }
 
+       fclose(procfile);
        return ret;
 }
 

diff --git a/iptables-xml.c b/iptables-xml.c
index e5d194197823366e053cec3ceaed8309fa2d0074..daf4208430d46da22b5bafb5800bb51b5f334cb9 100644 (file)
--- a/iptables-xml.c
+++ b/iptables-xml.c
@@ -870,6 +870,8 @@ main(int argc, char *argv[])
                exit(1);
        }
 
+       if (in != NULL)
+               fclose(in);
        printf("</iptables-rules>\n");
        free_argv();