- djm@cvs.openbsd.org 2013/12/02 02:56:17

     [ssh-pkcs11-helper.c]
     use-after-free; bz#2175 patch from Loganaden Velvindron @ AfriNIC

diff --git a/ChangeLog b/ChangeLog
index 1aa9e80e1f2fb67862f928dd8c8b59659172bacd..ef9ad85153a95945b71105e3933eec69fa8d4986 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -26,6 +26,9 @@
    - djm@cvs.openbsd.org 2013/12/02 02:50:27
      [PROTOCOL.chacha20poly1305]
      typo; from Jon Cave
+   - djm@cvs.openbsd.org 2013/12/02 02:56:17
+     [ssh-pkcs11-helper.c]
+     use-after-free; bz#2175 patch from Loganaden Velvindron @ AfriNIC
 
 20131121
  - (djm) OpenBSD CVS Sync

diff --git a/ssh-pkcs11-helper.c b/ssh-pkcs11-helper.c
index 39b2e7c566410591082ac0b4306d3e767440e8fd..b7c52beb8e66d3f06bb8d3c4741379d581a6c745 100644 (file)
--- a/ssh-pkcs11-helper.c
+++ b/ssh-pkcs11-helper.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-pkcs11-helper.c,v 1.6 2013/05/17 00:13:14 djm Exp $ */
+/* $OpenBSD: ssh-pkcs11-helper.c,v 1.7 2013/12/02 02:56:17 djm Exp $ */
 /*
  * Copyright (c) 2010 Markus Friedl.  All rights reserved.
  *
@@ -127,7 +127,8 @@ process_add(void)
                buffer_put_char(&msg, SSH2_AGENT_IDENTITIES_ANSWER);
                buffer_put_int(&msg, nkeys);
                for (i = 0; i < nkeys; i++) {
-                       key_to_blob(keys[i], &blob, &blen);
+                       if (key_to_blob(keys[i], &blob, &blen) == 0)
+                               continue;
                        buffer_put_string(&msg, blob, blen);
                        buffer_put_cstring(&msg, name);
                        free(blob);