]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: fix using cpufreq-dt as module
authorAndreas Kemnade <andreas@kemnade.info>
Sun, 3 Nov 2024 21:02:51 +0000 (22:02 +0100)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 23 Dec 2024 10:56:43 +0000 (16:26 +0530)
This driver can be built as a module since commit 3b062a086984 ("cpufreq:
dt-platdev: Support building as module"), but unfortunately this caused
a regression because the cputfreq-dt-platdev.ko module does not autoload.

Usually, this is solved by just using the MODULE_DEVICE_TABLE() macro to
export all the device IDs as module aliases. But this driver is special
due how matches with devices and decides what platform supports.

There are two of_device_id lists, an allow list that are for CPU devices
that always match and a deny list that's for devices that must not match.

The driver registers a cpufreq-dt platform device for all the CPU device
nodes that either are in the allow list or contain an operating-points-v2
property and are not in the deny list.

Enforce builtin compile of cpufreq-dt-platdev to make autoload work.

Fixes: 3b062a086984 ("cpufreq: dt-platdev: Support building as module")
Link: https://lore.kernel.org/all/20241104201424.2a42efdd@akair/
Link: https://lore.kernel.org/all/20241119111918.1732531-1-javierm@redhat.com/
Cc: stable@vger.kernel.org
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reported-by: Radu Rendec <rrendec@redhat.com>
Reported-by: Javier Martinez Canillas <javierm@redhat.com>
[ Viresh: Picked commit log from Javier, updated tags ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/Kconfig
drivers/cpufreq/cpufreq-dt-platdev.c

index 92a83a9bb2e10540e9e469df69d77ba39147cbca..ea9afdc119fbf1240048790c9c5c45aba799499d 100644 (file)
@@ -232,7 +232,7 @@ config CPUFREQ_VIRT
          If in doubt, say N.
 
 config CPUFREQ_DT_PLATDEV
-       tristate "Generic DT based cpufreq platdev driver"
+       bool "Generic DT based cpufreq platdev driver"
        depends on OF
        help
          This adds a generic DT based cpufreq platdev driver for frequency
index 2a3e8bd317c9d25b90a4554462d7c5d892981b89..9c198bd4f7e9b2fa174b1bc7f8c3e10dc735ea01 100644 (file)
@@ -235,5 +235,3 @@ create_pdev:
                               sizeof(struct cpufreq_dt_platform_data)));
 }
 core_initcall(cpufreq_dt_platdev_init);
-MODULE_DESCRIPTION("Generic DT based cpufreq platdev driver");
-MODULE_LICENSE("GPL");