]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
sstatesig: Improve output hash calculation
authorMateusz Marciniec <mateuszmar2@gmail.com>
Fri, 10 Feb 2023 23:18:34 +0000 (00:18 +0100)
committerSteve Sakoman <steve@sakoman.com>
Sat, 25 Feb 2023 19:25:51 +0000 (09:25 -1000)
Symbolic links to the files are included during the output hash
calculation but symlinks to the directories are missed.
So if the new symlink to a directory was the only change made,
then the output hash won't change,
and the Hash Equivalence server may change unihash.
In the next run bitbake may use an older package from sstate-cache.

To fix this followlinks=True flag could be set for os.walk
but it can lead to infinite recursion if link points
to a parent directory of itself.
Also, all files from a directory to which symlink points
would be included in depsig file.
Therefore another solution was applied, I added code that will loop
through directories and process those that are symlinks.

Signed-off-by: Mateusz Marciniec <mateuszmar2@gmail.com>
Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit ee729163f31f26b1462a47e1e53f7a0f9de9b464)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oe/sstatesig.py

index bf48aed7e114ea709624a5b805455c6613ab5d33..fb4abe82419d5840b8947dec733d5e92e75e9621 100644 (file)
@@ -662,6 +662,10 @@ def OEOuthashBasic(path, sigfile, task, d):
                 if f == 'fixmepath':
                     continue
                 process(os.path.join(root, f))
+
+            for dir in dirs:
+                if os.path.islink(os.path.join(root, dir)):
+                    process(os.path.join(root, dir))
     finally:
         os.chdir(prev_dir)