]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Use USEC_PER_MSEC rather than the hard coding
authorHimal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Wed, 20 Mar 2024 08:33:25 +0000 (14:03 +0530)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 21 Mar 2024 13:00:54 +0000 (06:00 -0700)
Use USEC_PER_MSEC rather than the hard coded value of 1000.

Static analyzer Reported "casting either timeout_ms or
1000U to type u64" to avoid overflow-before-widen.
Using USEC_PER_MSEC seems better and will help with static analyzer
report cleanup.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240320083325.3258720-1-himal.prasad.ghimiray@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_pcode.c

index b324dc2a5debe870f8e7edad1b0262d009f0be63..627e094c7cbe89ef2b0e29ab52f2649ff7a63303 100644 (file)
@@ -74,7 +74,7 @@ static int pcode_mailbox_rw(struct xe_gt *gt, u32 mbox, u32 *data0, u32 *data1,
        xe_mmio_write32(gt, PCODE_MAILBOX, PCODE_READY | mbox);
 
        err = xe_mmio_wait32(gt, PCODE_MAILBOX, PCODE_READY, 0,
-                            timeout_ms * 1000, NULL, atomic);
+                            timeout_ms * USEC_PER_MSEC, NULL, atomic);
        if (err)
                return err;