]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Remove the empty user-defined destructor of DNSResourceRecord 8763/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 29 Jan 2020 14:41:45 +0000 (15:41 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 29 Jan 2020 14:41:45 +0000 (15:41 +0100)
Having a user-defined destructor prevents the compiler from generating
implicit definition of the move constructor and the move assignment
operator, which might have a serious performance impact.

pdns/dns.hh

index adc8536dbe247d06d1ee76082017675887c30bfc..8a138476cbd964e387f13d9d5c23cade20d6a63f 100644 (file)
@@ -82,7 +82,6 @@ class DNSResourceRecord
 {
 public:
   DNSResourceRecord() : last_modified(0), ttl(0), signttl(0), domain_id(-1), qclass(1), scopeMask(0), auth(1), disabled(0) {};
-  ~DNSResourceRecord(){};
   static DNSResourceRecord fromWire(const DNSRecord& d);
 
   enum Place : uint8_t {QUESTION=0, ANSWER=1, AUTHORITY=2, ADDITIONAL=3}; //!< Type describing the positioning within, say, a DNSPacket