CLEANUP: httpclient: Remove useless test on ss_dst in httpclient_applet_init()

In httpclient_applet_init() function, ss_dst variable is always defined
before the call to sockaddr_alloc(). There is no reason to test it.

This patch should fix the issue #1706.

diff --git a/src/http_client.c b/src/http_client.c
index 53086a3aa1b037ce26772f66cc66eb651b369c87..160ea1b93a7ea7923884e546f1f9bd585298d8b1 100644 (file)
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -971,11 +971,6 @@ static int httpclient_applet_init(struct appctx *appctx)
                sock_inet_set_port(ss_dst, port);
        }
 
-       if (!ss_dst) {
-               ha_alert("httpclient: Failed to initialize address %s:%d.\n", __FUNCTION__, __LINE__);
-               goto out_error;
-       }
-
        if (!sockaddr_alloc(&addr, ss_dst, sizeof(*ss_dst)))
                goto out_error;