[gdb/testsuite, tclint] Fix gdb.perf

Running tclint on the test-cases in gdb.perf shows a few problems.

Fix these.

Tested on x86_64-linux.

diff --git a/gdb/tclint.toml b/gdb/tclint.toml
index b67f7d03b29c57b4a3eec5491c87507eb242530e..0f62e5ff821c3aee6450a92c49c748aa5ef30da6 100644 (file)
--- a/gdb/tclint.toml
+++ b/gdb/tclint.toml
@@ -29,7 +29,6 @@ exclude = [
 "gdb/testsuite/gdb.guile",
 "gdb/testsuite/gdb.mi",
 "gdb/testsuite/gdb.opencl",
-"gdb/testsuite/gdb.perf",
 "gdb/testsuite/gdb.python",
 "gdb/testsuite/gdb.reverse",
 "gdb/testsuite/gdb.threads",

diff --git a/gdb/testsuite/gdb.perf/backtrace.exp b/gdb/testsuite/gdb.perf/backtrace.exp
index 212298e55d6fa5c167c3312a16787034800aeb1b..aea1e01218141dbb6b7a15c1f3d74daea09885fa 100644 (file)
--- a/gdb/testsuite/gdb.perf/backtrace.exp
+++ b/gdb/testsuite/gdb.perf/backtrace.exp
@@ -28,7 +28,7 @@ set executable $testfile
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='backtrace.exp BACKTRACE_DEPTH=1024'
-if ![info exists BACKTRACE_DEPTH] {
+if {![info exists BACKTRACE_DEPTH]} {
     set BACKTRACE_DEPTH 64
 }
 

diff --git a/gdb/testsuite/gdb.perf/gmonster1.exp b/gdb/testsuite/gdb.perf/gmonster1.exp
index f7520627ad93dda46cd634a4147fb0bfbfb0a3fa..8bb748dd38148609fcb0e2784a3e0d5bfa0eed30 100644 (file)
--- a/gdb/testsuite/gdb.perf/gmonster1.exp
+++ b/gdb/testsuite/gdb.perf/gmonster1.exp
@@ -38,7 +38,7 @@ load_lib gen-perf-test.exp
 
 require allow_perf_tests
 
-if ![info exists MONSTER] {
+if {![info exists MONSTER]} {
     set MONSTER "n"
 }
 

diff --git a/gdb/testsuite/gdb.perf/gmonster2.exp b/gdb/testsuite/gdb.perf/gmonster2.exp
index ba4e46bde6ac2e49acecd4efc374b6056970a113..7049bce43ec7e73002145c2a766af28012d4f9e9 100644 (file)
--- a/gdb/testsuite/gdb.perf/gmonster2.exp
+++ b/gdb/testsuite/gdb.perf/gmonster2.exp
@@ -38,7 +38,7 @@ load_lib gen-perf-test.exp
 
 require allow_perf_tests
 
-if ![info exists MONSTER] {
+if {![info exists MONSTER]} {
     set MONSTER "n"
 }
 

diff --git a/gdb/testsuite/gdb.perf/single-step.exp b/gdb/testsuite/gdb.perf/single-step.exp
index 354203ed136d7d128113e83f013f5c98f2fa140d..8ec32d17598b805b7c9ba52115c264b192b1e36b 100644 (file)
--- a/gdb/testsuite/gdb.perf/single-step.exp
+++ b/gdb/testsuite/gdb.perf/single-step.exp
@@ -26,7 +26,7 @@ set executable $testfile
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='single-step.exp SINGLE_STEP_COUNT=300'
-if ![info exists SINGLE_STEP_COUNT] {
+if {![info exists SINGLE_STEP_COUNT]} {
     set SINGLE_STEP_COUNT 1000
 }
 

diff --git a/gdb/testsuite/gdb.perf/skip-command.exp b/gdb/testsuite/gdb.perf/skip-command.exp
index 99ecad8f88902dbcca8508cb9d0e885db6bb4c1d..e59cb07157bb77136e7f70faf0826713733f160a 100644 (file)
--- a/gdb/testsuite/gdb.perf/skip-command.exp
+++ b/gdb/testsuite/gdb.perf/skip-command.exp
@@ -33,10 +33,10 @@ set skip_func_file [standard_output_file $srcfile2]
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='skip-command.exp SKIP_STEP_COUNT=1000 ...'
-if ![info exists SKIP_STEP_COUNT] {
+if {![info exists SKIP_STEP_COUNT]} {
     set SKIP_STEP_COUNT 1000
 }
-if ![info exists SKIP_DIRECTIVE_COUNT] {
+if {![info exists SKIP_DIRECTIVE_COUNT]} {
     set SKIP_DIRECTIVE_COUNT 1000
 }
 
@@ -91,7 +91,7 @@ proc write_skip_func_source { file_name func_name_prefix nr_funcs } {
 proc run_skip_bench { kind text } {
     global SKIP_STEP_COUNT SKIP_DIRECTIVE_COUNT
 
-    if ![runto_main] {
+    if {![runto_main]} {
        return -1
     }
 

diff --git a/gdb/testsuite/gdb.perf/skip-prologue.exp b/gdb/testsuite/gdb.perf/skip-prologue.exp
index dbeb9f8ecb358e41251ad1616b884dfbd2e7f188..880a0f4a94314a71a62a9776fe917cb194ed3745 100644 (file)
--- a/gdb/testsuite/gdb.perf/skip-prologue.exp
+++ b/gdb/testsuite/gdb.perf/skip-prologue.exp
@@ -28,7 +28,7 @@ set executable $testfile
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='skip-prologue.exp SKIP_PROLOGUE_COUNT=500'
-if ![info exists SKIP_PROLOGUE_COUNT] {
+if {![info exists SKIP_PROLOGUE_COUNT]} {
     set SKIP_PROLOGUE_COUNT 500
 }
 

diff --git a/gdb/testsuite/gdb.perf/solib.exp b/gdb/testsuite/gdb.perf/solib.exp
index 1775bf6b8567ae3815b1c8159be4e99d9818f2db..e7870f65e99ca51411d886dcb92024c80a9149b7 100644 (file)
--- a/gdb/testsuite/gdb.perf/solib.exp
+++ b/gdb/testsuite/gdb.perf/solib.exp
@@ -31,7 +31,7 @@ set executable $testfile
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='solib.exp SOLIB_COUNT=1024'
-if ![info exists SOLIB_COUNT] {
+if {![info exists SOLIB_COUNT]} {
     set SOLIB_COUNT 128
 }
 

diff --git a/gdb/testsuite/gdb.perf/template-breakpoints.exp b/gdb/testsuite/gdb.perf/template-breakpoints.exp
index db57731f4029038ad3ae736a88adc4eef0c8367e..e5d21b2a11c23541cb1d3d0c08e1a560c748202e 100644 (file)
--- a/gdb/testsuite/gdb.perf/template-breakpoints.exp
+++ b/gdb/testsuite/gdb.perf/template-breakpoints.exp
@@ -28,7 +28,7 @@ set executable $testfile
 set expfile $testfile.exp
 
 # make check-perf RUNTESTFLAGS='template-breakpoints.exp EXPANSION_DEPTH=40'
-if ![info exists EXPANSION_DEPTH] {
+if {![info exists EXPANSION_DEPTH]} {
        set EXPANSION_DEPTH 40
 }