]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drivers/perf: hisi: Don't update the associated_cpus on CPU offline
authorYicong Yang <yangyicong@hisilicon.com>
Tue, 10 Dec 2024 14:15:17 +0000 (22:15 +0800)
committerWill Deacon <will@kernel.org>
Tue, 10 Dec 2024 15:57:24 +0000 (15:57 +0000)
Event will be scheduled on CPU of hisi_pmu::on_cpu which is selected
from the intersection of hisi_pmu::associated_cpus and online CPUs.
So the associated_cpus don't need to be maintained with online CPUs.
This will save one update operation if one associated CPU is offlined.

Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20241210141525.37788-3-yangyicong@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/hisilicon/hisi_uncore_pmu.c

index 749d3362598082f20175bebeabba42961d21862a..8c404f8b3f39dbb650376fc3b2f66d8c32a3bfc3 100644 (file)
@@ -492,9 +492,6 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
                                                     node);
        unsigned int target;
 
-       if (!cpumask_test_and_clear_cpu(cpu, &hisi_pmu->associated_cpus))
-               return 0;
-
        /* Nothing to do if this CPU doesn't own the PMU */
        if (hisi_pmu->on_cpu != cpu)
                return 0;