lib-storage: Make sure istream-mail doesn't replace an existing storage error

I'm not aware of it actually having broken anything, so this is just for
extra safety.

diff --git a/src/lib-storage/index/istream-mail.c b/src/lib-storage/index/istream-mail.c
index f49e7ef78ecda406945a2d6b95f27913a43d531d..7c278af25b7e75e2ffb6e3e9d3bf752a2e2e44cb 100644 (file)
--- a/src/lib-storage/index/istream-mail.c
+++ b/src/lib-storage/index/istream-mail.c
@@ -23,11 +23,15 @@ static bool i_stream_mail_try_get_cached_size(struct mail_istream *mstream)
        if (mstream->expected_size != (uoff_t)-1)
                return TRUE;
 
+       /* make sure this call doesn't change any existing error message,
+          just in case there's already something important in it. */
+       mail_storage_last_error_push(mail->box->storage);
        orig_lookup_abort = mail->lookup_abort;
        mail->lookup_abort = MAIL_LOOKUP_ABORT_NOT_IN_CACHE;
        if (mail_get_physical_size(mail, &mstream->expected_size) < 0)
                mstream->expected_size = (uoff_t)-1;
        mail->lookup_abort = orig_lookup_abort;
+       mail_storage_last_error_pop(mail->box->storage);
        return mstream->expected_size != (uoff_t)-1;
 }