]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ARM: versatile: fix OF node leak in CPUs prepare
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 26 Aug 2024 05:49:33 +0000 (07:49 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 2 Sep 2024 08:18:43 +0000 (10:18 +0200)
Machine code is leaking OF node reference from of_find_matching_node()
in realview_smp_prepare_cpus().

Fixes: 5420b4b15617 ("ARM: realview: add an DT SMP boot method")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://lore.kernel.org/20240826054934.10724-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
arch/arm/mach-versatile/platsmp-realview.c

index 6965a1de727b07fbd3626bd4c984ccc7e720c5bc..d38b2e174257e8e673950de9aaf57a124c089292 100644 (file)
@@ -70,6 +70,7 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
                return;
        }
        map = syscon_node_to_regmap(np);
+       of_node_put(np);
        if (IS_ERR(map)) {
                pr_err("PLATSMP: No syscon regmap\n");
                return;