]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t/gitweb-lib.sh: drop confusing quotes
authorJeff King <peff@peff.net>
Fri, 15 Nov 2019 09:06:01 +0000 (04:06 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 18 Nov 2019 01:46:30 +0000 (10:46 +0900)
Some variables assignments in gitweb_run() look like this:

  FOO=""$1""

The extra quotes aren't doing anything. Each set opens and closes an
empty string, and $1 is actually outside of any double-quotes (which is
OK, because variable assignment does not do whitespace splitting on the
expanded value).

Let's drop them, as they're simply confusing.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/gitweb-lib.sh

index 006d2a8152dc499f3588b130470285703b60dc92..130c7ed64fc162e86ecfa78b12ea908fa0bc3f78 100644 (file)
@@ -58,8 +58,8 @@ gitweb_run () {
        GATEWAY_INTERFACE='CGI/1.1'
        HTTP_ACCEPT='*/*'
        REQUEST_METHOD='GET'
-       QUERY_STRING=""$1""
-       PATH_INFO=""$2""
+       QUERY_STRING=$1
+       PATH_INFO=$2
        export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
                QUERY_STRING PATH_INFO