]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_open.c: fix Coverity CID#13676 Dereference before null check
authorMarek Schimara <Marek.Schimara@bull.net>
Fri, 17 Jun 2016 07:45:28 +0000 (09:45 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-476 / https://cwe.mitre.org/data/definitions/476.html

src/rrd_open.c

index 3bb2726636f138f8b717c89f288d0dff5b3e1e4e..ec4ae2e0187a3d3a8ae7152b1b8f5330abbd2dbf 100644 (file)
@@ -586,7 +586,7 @@ void rrd_dontneed(
     rrd_file_t *rrd_file,
     rrd_t *rrd)
 {
-    rrd_simple_file_t *rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt;
+    rrd_simple_file_t *rrd_simple_file;
 #if defined USE_MADVISE || defined HAVE_POSIX_FADVISE
     size_t dontneed_start;
     size_t rra_start;
@@ -600,6 +600,7 @@ void rrd_dontneed(
 #endif
            return;
     }
+    rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt;
 
 #if defined DEBUG && DEBUG > 1
     mincore_print(rrd_file, "before");