]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
tests/functional: remove pointless with statement
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 29 Nov 2024 17:31:02 +0000 (17:31 +0000)
committerThomas Huth <thuth@redhat.com>
Wed, 11 Dec 2024 08:19:12 +0000 (09:19 +0100)
The xorriso command directly writes to 'filename', so the surrounding
'with' statement is pointless.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241129173120.761728-5-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/functional/test_ppc64_hv.py

index 312248bbfe4d5ac570664d45f16581c39fd3f9c9..d97b62e364fd6583f1a3631a173d6604869d6734 100755 (executable)
@@ -72,10 +72,9 @@ class HypervisorTest(QemuSystemTest):
         cwd = os.getcwd()
         os.chdir(self.workdir)
 
-        with open(filename, "w") as outfile:
-            cmd = "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, path, filename)
-            subprocess.run(cmd.split(),
-                           stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+        cmd = "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, path, filename)
+        subprocess.run(cmd.split(),
+                       stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
 
         os.chmod(filename, 0o600)
         os.chdir(cwd)