]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
non-ascii: Reduce variable scope
authorSteve Holme <steve_holme@hotmail.com>
Fri, 19 Dec 2014 20:29:56 +0000 (20:29 +0000)
committerSteve Holme <steve_holme@hotmail.com>
Sat, 20 Dec 2014 12:38:31 +0000 (12:38 +0000)
As 'result' isn't used out side the conversion callback code and
previously caused variable shadowing in the libiconv based code.

lib/non-ascii.c

index bfe065054837185bdac3b715df6d4328522bf0f3..ef6a82ceae527903cd94288d7dab81feeb9cf3cb 100644 (file)
@@ -82,16 +82,15 @@ CURLcode Curl_convert_clone(struct SessionHandle *data,
 CURLcode Curl_convert_to_network(struct SessionHandle *data,
                                  char *buffer, size_t length)
 {
-  CURLcode result;
-
   if(data->set.convtonetwork) {
     /* use translation callback */
-    result = data->set.convtonetwork(buffer, length);
+    CURLcode result = data->set.convtonetwork(buffer, length);
     if(result) {
       failf(data,
             "CURLOPT_CONV_TO_NETWORK_FUNCTION callback returned %d: %s",
             (int)result, curl_easy_strerror(result));
     }
+
     return result;
   }
   else {
@@ -143,16 +142,15 @@ CURLcode Curl_convert_to_network(struct SessionHandle *data,
 CURLcode Curl_convert_from_network(struct SessionHandle *data,
                                    char *buffer, size_t length)
 {
-  CURLcode result;
-
   if(data->set.convfromnetwork) {
     /* use translation callback */
-    result = data->set.convfromnetwork(buffer, length);
+    CURLcode result = data->set.convfromnetwork(buffer, length);
     if(result) {
       failf(data,
             "CURLOPT_CONV_FROM_NETWORK_FUNCTION callback returned %d: %s",
             (int)result, curl_easy_strerror(result));
     }
+
     return result;
   }
   else {
@@ -204,16 +202,15 @@ CURLcode Curl_convert_from_network(struct SessionHandle *data,
 CURLcode Curl_convert_from_utf8(struct SessionHandle *data,
                                 char *buffer, size_t length)
 {
-  CURLcode result;
-
   if(data->set.convfromutf8) {
     /* use translation callback */
-    result = data->set.convfromutf8(buffer, length);
+    CURLcode result = data->set.convfromutf8(buffer, length);
     if(result) {
       failf(data,
             "CURLOPT_CONV_FROM_UTF8_FUNCTION callback returned %d: %s",
             (int)result, curl_easy_strerror(result));
     }
+
     return result;
   }
   else {