ACPI: fan: Bail out if extract package failed

Bail out if we extract the _FIF package failed, or we will end
of referencing the garbage information in fields[], the fan control
will be in mess, fix it.

Fiexes: d445571fa369 ("ACPI: fan: Optimize struct acpi_fan_fif")
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
index 52a0b303b70aab742a5090c720cb8df5ff8eedc1..9dccbae9e8ea76b743f1e00d128b89883f713316 100644 (file)
--- a/drivers/acpi/fan_core.c
+++ b/drivers/acpi/fan_core.c
@@ -236,6 +236,7 @@ static int acpi_fan_get_fif(struct acpi_device *device)
        if (ACPI_FAILURE(status)) {
                dev_err(&device->dev, "Invalid _FIF element\n");
                status = -EINVAL;
+               goto err;
        }
 
        fan->fif.revision = fields[0];