gunit/009: fix string truncation warnings

Fix string truncation warnings across the test case:

009-cgroup_set_values_recursive.cpp: In member function ‘virtual void SetValuesRecursiveTest_SuccessfulSetValues_Test::TestBody()’:
009-cgroup_set_values_recursive.cpp:96:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 4096 equals destination size [-Wstringop-truncation]
   strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX);
   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
009-cgroup_set_values_recursive.cpp:97:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 4096 equals destination size [-Wstringop-truncation]
   strncpy(ctrlr.values[i]->value, VALUES[i],
   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    CG_CONTROL_VALUE_MAX);
    ~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/tests/gunit/009-cgroup_set_values_recursive.cpp b/tests/gunit/009-cgroup_set_values_recursive.cpp
index 0e7b09d8d0e17ee0e47520aeb044f98efd163ae8..933da95cb576766d090bc4f6a44028b4d833bbc0 100644 (file)
--- a/tests/gunit/009-cgroup_set_values_recursive.cpp
+++ b/tests/gunit/009-cgroup_set_values_recursive.cpp
@@ -93,9 +93,13 @@ TEST_F(SetValuesRecursiveTest, SuccessfulSetValues)
                                        sizeof(struct control_value));
                ASSERT_NE(ctrlr.values[i], nullptr);
 
-               strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX);
+               strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX - 1);
+               ctrlr.values[i]->name[FILENAME_MAX - 1] = '\0';
+
                strncpy(ctrlr.values[i]->value, VALUES[i],
-                       CG_CONTROL_VALUE_MAX);
+                       CG_CONTROL_VALUE_MAX - 1);
+               ctrlr.values[i]->value[CG_CONTROL_VALUE_MAX - 1] = '\0';
+
                if (i == 0)
                        ctrlr.values[i]->dirty = true;
                else