]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: airoha: fix pinctrl function mismatch issue
authorChukun Pan <amadeus@jmu.edu.cn>
Sat, 15 Nov 2025 10:00:00 +0000 (18:00 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 18 Nov 2025 23:02:24 +0000 (00:02 +0100)
The blamed commit made the following changes:

-#define PINCTRL_FUNC_DESC(id)...
- .desc = PINCTRL_PINFUNCTION(#id, ...
+#define PINCTRL_FUNC_DESC(id, table)...
+ .desc = PINCTRL_PINFUNCTION(#id, ...

- PINCTRL_FUNC_DESC(pon)...
+ PINCTRL_FUNC_DESC("pon", pon)...

It's clear that the id of funcs doesn't match the definition.
Remove redundant #string from the definition to fix this issue:
pinctrl-airoha ...: invalid function mdio in map table

Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Acked-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-airoha.c

index 983d96fd399a2d348de7f18a343d578c2a33f671..2a5b9b6f08d9ea0e343ca1b4b32707704a5cce77 100644 (file)
@@ -35,7 +35,7 @@
 
 #define PINCTRL_FUNC_DESC(id, table)                                   \
        {                                                               \
-               .desc = PINCTRL_PINFUNCTION(#id, table##_groups,        \
+               .desc = PINCTRL_PINFUNCTION(id, table##_groups, \
                                            ARRAY_SIZE(table##_groups)),\
                .groups = table##_func_group,                           \
                .group_size = ARRAY_SIZE(table##_func_group),           \