]> git.ipfire.org Git - thirdparty/git.git/commitdiff
tr2: clarify TRACE2_PROCESS_INFO_EXIT comment under Linux
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 27 Aug 2021 08:02:14 +0000 (10:02 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 7 Sep 2021 18:07:59 +0000 (11:07 -0700)
Rewrite a comment added in 2f732bf15e6 (tr2: log parent process name,
2021-07-21) to describe what we might do under
TRACE2_PROCESS_INFO_EXIT in the future, instead of vaguely referring
to "something extra".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/linux/procinfo.c

index 15a89676c7a618a2e519219c7757bbb9eb6dc5d2..62f8aaed4cc9e76109df397ca230322eaad968f3 100644 (file)
@@ -32,8 +32,12 @@ void trace2_collect_process_info(enum trace2_process_info_reason reason)
        if (!trace2_is_enabled())
                return;
 
-       /* someday we may want to write something extra here, but not today */
        if (reason == TRACE2_PROCESS_INFO_EXIT)
+               /*
+                * The Windows version of this calls its
+                * get_peak_memory_info() here. We may want to insert
+                * similar process-end statistics here in the future.
+                */
                return;
 
        if (reason == TRACE2_PROCESS_INFO_STARTUP) {