]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
xtables: arp: Parse properly target options
authorTomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Thu, 3 Oct 2013 13:00:47 +0000 (16:00 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 30 Dec 2013 22:50:50 +0000 (23:50 +0100)
Target never gets its options parsed.

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
iptables/xtables-arp.c

index 8072d90d978171a57ec9fb9bbb4149192addec2c..411a6998640026bfef81ec07719d2d18fce4ec53 100644 (file)
@@ -1317,6 +1317,10 @@ int do_commandarp(struct nft_handle *h, int argc, char *argv[], char **table)
                        exit_tryhelp(2);
 
                default:
+                       if (target) {
+                               xtables_option_tpcall(c, argv,
+                                                     invert, target, &fw);
+                       }
                        break;
                }
                invert = FALSE;
@@ -1325,8 +1329,6 @@ int do_commandarp(struct nft_handle *h, int argc, char *argv[], char **table)
        if (target)
                xtables_option_tfcall(target);
 
-       /* Fix me: must put inverse options checking here --MN */
-
        if (optind < argc)
                xtables_error(PARAMETER_PROBLEM,
                              "unknown arguments found on commandline");