]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Jan 2019 09:27:42 +0000 (10:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Jan 2019 09:27:42 +0000 (10:27 +0100)
added patches:
staging-wilc1000-fix-missing-read_write-setting-when-reading-data.patch

queue-4.14/series
queue-4.14/staging-wilc1000-fix-missing-read_write-setting-when-reading-data.patch [new file with mode: 0644]

index c691a5f21684d9ad1ea8966d07a0c81813cfbe7b..fccad20ea8825d745da8c58cb75fdb4088b736de 100644 (file)
@@ -50,3 +50,4 @@ alsa-hda-tegra-clear-pending-irq-handlers.patch
 usb-serial-pl2303-add-ids-for-hewlett-packard-hp-pos-pole-displays.patch
 usb-serial-option-add-fibocom-nl678-series.patch
 usb-r8a66597-fix-a-possible-concurrency-use-after-free-bug-in-r8a66597_endpoint_disable.patch
+staging-wilc1000-fix-missing-read_write-setting-when-reading-data.patch
diff --git a/queue-4.14/staging-wilc1000-fix-missing-read_write-setting-when-reading-data.patch b/queue-4.14/staging-wilc1000-fix-missing-read_write-setting-when-reading-data.patch
new file mode 100644 (file)
index 0000000..2169ffe
--- /dev/null
@@ -0,0 +1,35 @@
+From c58eef061dda7d843dcc0ad6fea7e597d4c377c0 Mon Sep 17 00:00:00 2001
+From: Colin Ian King <colin.king@canonical.com>
+Date: Wed, 19 Dec 2018 16:30:07 +0000
+Subject: staging: wilc1000: fix missing read_write setting when reading data
+
+From: Colin Ian King <colin.king@canonical.com>
+
+commit c58eef061dda7d843dcc0ad6fea7e597d4c377c0 upstream.
+
+Currently the cmd.read_write setting is not initialized so it contains
+garbage from the stack.  Fix this by setting it to 0 to indicate a
+read is required.
+
+Detected by CoverityScan, CID#1357925 ("Uninitialized scalar variable")
+
+Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
+Signed-off-by: Colin Ian King <colin.king@canonical.com>
+Cc: stable <stable@vger.kernel.org>
+Acked-by: Ajay Singh <ajay.kathat@microchip.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/staging/wilc1000/wilc_sdio.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/drivers/staging/wilc1000/wilc_sdio.c
++++ b/drivers/staging/wilc1000/wilc_sdio.c
+@@ -823,6 +823,7 @@ static int sdio_read_int(struct wilc *wi
+       if (!g_sdio.irq_gpio) {
+               int i;
++              cmd.read_write = 0;
+               cmd.function = 1;
+               cmd.address = 0x04;
+               cmd.data = 0;