global: hash_table_iterate_deinit(NULL) is a no-op

@@
expression E;
@@

- if (E != NULL) {
- 	hash_table_iterate_deinit(&E);
- }
+ hash_table_iterate_deinit(&E);

diff --git a/src/doveadm/dsync/dsync-brain.c b/src/doveadm/dsync/dsync-brain.c
index 6bc013ff538438fdb518a0beaa84b4f89066aa8a..72b62a3ea200c66cde6a3028dc129e2713e4443d 100644 (file)
--- a/src/doveadm/dsync/dsync-brain.c
+++ b/src/doveadm/dsync/dsync-brain.c
@@ -366,8 +366,7 @@ int dsync_brain_deinit(struct dsync_brain **_brain, enum mail_error *error_r)
                dsync_mailbox_tree_deinit(&brain->local_mailbox_tree);
        if (brain->remote_mailbox_tree != NULL)
                dsync_mailbox_tree_deinit(&brain->remote_mailbox_tree);
-       if (brain->mailbox_states_iter != NULL)
-               hash_table_iterate_deinit(&brain->mailbox_states_iter);
+       hash_table_iterate_deinit(&brain->mailbox_states_iter);
        hash_table_destroy(&brain->mailbox_states);
 
        pool_unref(&brain->dsync_box_pool);