]> git.ipfire.org Git - thirdparty/starlette.git/commitdiff
Remove routing decorators in test_gzip.py (#1497)
authorAmin Alaee <mohammadamin.alaee@gmail.com>
Thu, 10 Feb 2022 09:25:00 +0000 (10:25 +0100)
committerGitHub <noreply@github.com>
Thu, 10 Feb 2022 09:25:00 +0000 (10:25 +0100)
tests/middleware/test_gzip.py

index b917ea4dbbdc6217f6f4fe1a41f52414ce1560bd..a9cedb33b6e98781548fa65c4ba7992079d0a634 100644 (file)
@@ -1,17 +1,19 @@
 from starlette.applications import Starlette
+from starlette.middleware import Middleware
 from starlette.middleware.gzip import GZipMiddleware
 from starlette.responses import PlainTextResponse, StreamingResponse
+from starlette.routing import Route
 
 
 def test_gzip_responses(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("x" * 4000, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200
@@ -21,14 +23,14 @@ def test_gzip_responses(test_client_factory):
 
 
 def test_gzip_not_in_accept_encoding(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("x" * 4000, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "identity"})
     assert response.status_code == 200
@@ -38,14 +40,14 @@ def test_gzip_not_in_accept_encoding(test_client_factory):
 
 
 def test_gzip_ignored_for_small_responses(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("OK", status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200
@@ -55,11 +57,6 @@ def test_gzip_ignored_for_small_responses(test_client_factory):
 
 
 def test_gzip_streaming_response(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         async def generator(bytes, count):
             for index in range(count):
@@ -68,6 +65,11 @@ def test_gzip_streaming_response(test_client_factory):
         streaming = generator(bytes=b"x" * 400, count=10)
         return StreamingResponse(streaming, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200