]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
UAPI: ndctl: Remove use of PAGE_SIZE
authorDavid Howells <dhowells@redhat.com>
Thu, 6 Sep 2018 09:19:30 +0000 (10:19 +0100)
committerDan Williams <dan.j.williams@intel.com>
Wed, 17 Oct 2018 20:56:58 +0000 (13:56 -0700)
The macro PAGE_SIZE isn't valid outside of the kernel, so it should not
appear in UAPI headers.

Furthermore, the actual machine page size could theoretically change from
an application's point of view if it's running in a container that gets
migrated to another machine (say 4K/ppc64 to 64K/ppc64).

Fixes: f2ba5a5baecf ("libnvdimm, namespace: make min namespace size 4K")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
include/linux/ndctl.h [new file with mode: 0644]
include/uapi/linux/ndctl.h

diff --git a/include/linux/ndctl.h b/include/linux/ndctl.h
new file mode 100644 (file)
index 0000000..cd5a293
--- /dev/null
@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2014-2016, Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU Lesser General Public License,
+ * version 2.1, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for
+ * more details.
+ */
+#ifndef _LINUX_NDCTL_H
+#define _LINUX_NDCTL_H
+
+#include <uapi/linux/ndctl.h>
+
+enum {
+       ND_MIN_NAMESPACE_SIZE = PAGE_SIZE,
+};
+
+#endif /* _LINUX_NDCTL_H */
index 2f2c43d633c59c25ca1dd43feb69e7b648639ece..f57c9e434d2d3bc5ca350ae81b73e1c96c8bc0a8 100644 (file)
@@ -202,10 +202,6 @@ enum nd_driver_flags {
        ND_DRIVER_DAX_PMEM        = 1 << ND_DEVICE_DAX_PMEM,
 };
 
-enum {
-       ND_MIN_NAMESPACE_SIZE = PAGE_SIZE,
-};
-
 enum ars_masks {
        ARS_STATUS_MASK = 0x0000FFFF,
        ARS_EXT_STATUS_SHIFT = 16,