]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pwm: lpss: drop redundant runtime PM handles
authorRaag Jadav <raag.jadav@intel.com>
Wed, 5 Jun 2024 13:15:33 +0000 (18:45 +0530)
committerUwe Kleine-König <ukleinek@kernel.org>
Wed, 10 Jul 2024 15:53:51 +0000 (17:53 +0200)
We no longer need empty runtime PM handles for PCI devices after
commits [1] and [2]. Drop them and let PCI core take care of power
state transitions.

[1] c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions")
[2] fa885b06ec7e ("PCI/PM: Allow runtime PM with no PM callbacks at all")

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Link: https://lore.kernel.org/r/20240605131533.20037-3-raag.jadav@intel.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-lpss-pci.c

index 25045c229520026c5affa9ac72a25458e6079f5e..f7ece2809e6bba49b6b9fa3e43bf9dfb051b8dde 100644 (file)
@@ -46,25 +46,6 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)
        pm_runtime_get_sync(&pdev->dev);
 }
 
-static int pwm_lpss_runtime_suspend_pci(struct device *dev)
-{
-       /*
-        * The PCI core will handle transition to D3 automatically. We only
-        * need to provide runtime PM hooks for that to happen.
-        */
-       return 0;
-}
-
-static int pwm_lpss_runtime_resume_pci(struct device *dev)
-{
-       return 0;
-}
-
-static DEFINE_RUNTIME_DEV_PM_OPS(pwm_lpss_pci_pm,
-                                pwm_lpss_runtime_suspend_pci,
-                                pwm_lpss_runtime_resume_pci,
-                                NULL);
-
 static const struct pci_device_id pwm_lpss_pci_ids[] = {
        { PCI_VDEVICE(INTEL, 0x0ac8), (unsigned long)&pwm_lpss_bxt_info},
        { PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info},
@@ -84,9 +65,6 @@ static struct pci_driver pwm_lpss_driver_pci = {
        .id_table = pwm_lpss_pci_ids,
        .probe = pwm_lpss_probe_pci,
        .remove = pwm_lpss_remove_pci,
-       .driver = {
-               .pm = pm_ptr(&pwm_lpss_pci_pm),
-       },
 };
 module_pci_driver(pwm_lpss_driver_pci);