]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov7740: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:26 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:25 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov7740.c

index 1f1c0de8e510d2d65de6ce1af5fd3584a3532a08..632fb80469bef6479862b4db1cbf03fd8fb52656 100644 (file)
@@ -1036,13 +1036,10 @@ static int ov7740_probe(struct i2c_client *client)
        if (!ov7740)
                return -ENOMEM;
 
-       ov7740->xvclk = devm_clk_get(&client->dev, "xvclk");
-       if (IS_ERR(ov7740->xvclk)) {
-               ret = PTR_ERR(ov7740->xvclk);
-               dev_err(&client->dev,
-                       "OV7740: fail to get xvclk: %d\n", ret);
-               return ret;
-       }
+       ov7740->xvclk = devm_v4l2_sensor_clk_get(&client->dev, "xvclk");
+       if (IS_ERR(ov7740->xvclk))
+               return dev_err_probe(&client->dev, PTR_ERR(ov7740->xvclk),
+                                    "OV7740: fail to get xvclk\n");
 
        ret = ov7740_probe_dt(client, ov7740);
        if (ret)